-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook for @storybook/blocks
only
#19630
Merged
JReinhold
merged 7 commits into
next
from
jeppe/sb-867-set-up-storybook-that-only-contains-doc
Oct 26, 2022
Merged
Storybook for @storybook/blocks
only
#19630
JReinhold
merged 7 commits into
next
from
jeppe/sb-867-set-up-storybook-that-only-contains-doc
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
commented
Oct 26, 2022
JReinhold
commented
Oct 26, 2022
JReinhold
commented
Oct 26, 2022
tmeasday
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…f github.com:storybookjs/storybook into jeppe/sb-867-set-up-storybook-that-only-contains-doc
JReinhold
deleted the
jeppe/sb-867-set-up-storybook-that-only-contains-doc
branch
October 26, 2022 21:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "adds" a new Storybook for
@storybook/blocks
only, that is just a subset of the UI Storybook.It uses the exact same configuraiton, but with fewer story globs based on the
BLOCKS_ONLY
env var.The Blocks SB is published to Chromatic too - but with UI Tests and Review disabled since they are redundant.