Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: Support SSR by not using global.window to store hooks context #19631

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ndelangen
Copy link
Member

In an effort to make it possible to serverside render storybook, this is one of many steps we'll have to take.

@ndelangen ndelangen self-assigned this Oct 26, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 26, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 this is wonderful 🙌

@shilman shilman changed the title change lib/addons tu not use global.window but global directly instead Addons: Support SSR by not using global.window to store hooks context Oct 26, 2022
@shilman shilman merged commit 1a8f11c into next Oct 26, 2022
@shilman shilman deleted the fix/use-of-window branch October 26, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants