Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename storybook/ui to storybook/manager #19635

Merged
merged 5 commits into from
Oct 27, 2022
Merged

rename storybook/ui to storybook/manager #19635

merged 5 commits into from
Oct 27, 2022

Conversation

ndelangen
Copy link
Member

rename @storybook/ui to @storybook/manager

@ndelangen ndelangen self-assigned this Oct 26, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 26, 2022
@ndelangen ndelangen requested a review from shilman October 26, 2022 16:11
@ndelangen ndelangen requested a review from JReinhold October 26, 2022 18:41
JReinhold
JReinhold approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Can you rename the titlePrefix in code/ui/.storybook/main.ts as well?

Since this is a public package, we need to mention it in MIGRATION.md right?

@ndelangen ndelangen merged commit 2c628b1 into next Oct 27, 2022
@ndelangen ndelangen deleted the tech/rename-lib-ui branch October 27, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @JReinhold