Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown autofixing on precommit hook #1964

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

It seems to be completely broken. If I commit something to README.md it just hangs — but that's not the worst part. If I commit both README.md and CONTRIBUTING.md at the same time, the contents of the former are replaced with those of the latter: 2f53feb#diff-04c6e90faac2675aa89e2176d2eec7d8

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #1964 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1964   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files         262      262           
  Lines        5757     5757           
  Branches      686      689    +3     
=======================================
  Hits         1231     1231           
+ Misses       4015     4005   -10     
- Partials      511      521   +10
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5465a...5530584. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team October 4, 2017 23:44
@dangreenisrael
Copy link
Member

dangreenisrael commented Oct 5, 2017

@Hypnosphi Should this also be done on 3.3 and new-docs?

@Hypnosphi
Copy link
Member Author

@dangreenisrael yes

@Hypnosphi Hypnosphi merged commit f355399 into master Oct 5, 2017
@Hypnosphi Hypnosphi deleted the remove-remark-autofix branch October 6, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants