Upgrade docs-mdx to fix yarn pnp #19835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
commented
Nov 15, 2022
| @@ -1,6 +1,6 @@ | |||
| import * as AStories from '../src/A.stories'; | |||
|
|
|||
| <!-- This is the same name as a story --> | |||
There was a problem hiding this comment.
this is invalid MDX but we never tested it because of the mocking
Updated snapshots seem right. I'm not sure how the template ones go in there in the first place.
I don't really recall this at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
https://discord.com/channels/486522875931656193/1041419369256853595/1041419369256853595
What I did
Upgrade the docs-mdx to a version that fixes its dependencies
How to test