Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community addon to add the ability to customize styles in the story preview area #2007

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

Sambego
Copy link
Contributor

@Sambego Sambego commented Oct 10, 2017

Added

  • A community addon to add the ability to customize styles in the story preview area.

a screenshot of the addon in action

### Added
- A community addon to add general styles to the preview area.
@Sambego Sambego changed the title Add communit addon storybook-styles Add community addon storybook-styles Oct 10, 2017
@codecov
Copy link

codecov bot commented Oct 10, 2017

Codecov Report

Merging #2007 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files         262      262           
  Lines        5767     5767           
  Branches      699      695    -4     
=======================================
  Hits         1231     1231           
- Misses       4006     4011    +5     
+ Partials      530      525    -5
Impacted Files Coverage Δ
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61c3df...62de300. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding general styling sounds really vague.

Perhaps something like Add ability to customize styles in the story preview area?

Also, your readme should include a bit more detail about what the plugin does, a short summary of how it accomplishes it, what the config parameters are (looks like they're just the standard js styles but might be worth a mention), and maybe a screenshot for what it does too.

These are just suggestions from me personally. I don't think we have strict guidelines as to what addons we include in the communities list

@Sambego Sambego changed the title Add community addon storybook-styles Add community addon to add the ability to customize styles in the story preview area Oct 11, 2017
@Sambego
Copy link
Contributor Author

Sambego commented Oct 11, 2017

@danielduan thanks for the pointers! I've updated the readme with a screenshot and some information about the accepted parameters.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@danielduan danielduan merged commit 848f2e3 into storybookjs:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants