-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add community addon to add the ability to customize styles in the story preview area #2007
Conversation
### Added - A community addon to add general styles to the preview area.
Codecov Report
@@ Coverage Diff @@
## master #2007 +/- ##
=======================================
Coverage 21.34% 21.34%
=======================================
Files 262 262
Lines 5767 5767
Branches 699 695 -4
=======================================
Hits 1231 1231
- Misses 4006 4011 +5
+ Partials 530 525 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding general styling sounds really vague.
Perhaps something like Add ability to customize styles in the story preview area
?
Also, your readme should include a bit more detail about what the plugin does, a short summary of how it accomplishes it, what the config parameters are (looks like they're just the standard js styles but might be worth a mention), and maybe a screenshot for what it does too.
These are just suggestions from me personally. I don't think we have strict guidelines as to what addons we include in the communities list
@danielduan thanks for the pointers! I've updated the readme with a screenshot and some information about the accepted parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Added