Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storyId access in instrumenter #20201

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix storyId access in instrumenter #20201

merged 1 commit into from
Dec 12, 2022

Conversation

valentinpalkovic
Copy link
Contributor

Issue:

What I did

492f730 introduced a change, which doesn't catch an undefined selection. It seems that storyId might be undefined.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic self-assigned this Dec 12, 2022
yannbf
yannbf approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good workaround, but we need to investigate things further!

@valentinpalkovic valentinpalkovic merged commit c79613c into next Dec 12, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/fix-story-id-access-in-instrumenter branch December 12, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
addon: interactions bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinpalkovic @yannbf @shilman