Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: add support for using Nuxt.js in dependencies section #2056

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

ikasumiwt
Copy link
Contributor

Issue: none
Related Pull-Requests: #1794

What I did

In my case, getstorybook command is failed when nuxt.js saved to "dependencies" in package.json.

So, I added "dependencies" checking in delect.js.

How to test

Is this testable with jest or storyshots?
No

Does this need a new example in the kitchen sink apps?
No

Does this need an update to the documentation?
No

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #2056 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2056   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files         262      262           
  Lines        5767     5767           
  Branches      693      699    +6     
=======================================
  Hits         1231     1231           
+ Misses       4017     4003   -14     
- Partials      519      533   +14
Impacted Files Coverage Δ
lib/cli/lib/detect.js 0% <ø> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3387bcd...6956d5e. Read the comment docs.

@psimyn psimyn merged commit cf6a678 into storybookjs:master Oct 16, 2017
@shilman shilman changed the title Add support for using Nuxt.js in dependensies section Vue: add support for using Nuxt.js in dependencies section Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants