-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: add more sandboxes to CI tests #20892
Conversation
53c5a6a
to
60d9535
Compare
I did some investigation on this, and I think it's a bug, and the failing test has caught that. The docs pages in:
I wonder if #18659 is related to this. |
Sounds like a bug @yannbf! Yay for tests :) |
@yannbf if you like disable the test and add an issue to fix+enable it? |
ae900da
to
00ac79e
Compare
00ac79e
to
c8aebdb
Compare
- html-vite js - html-vite ts - qwik-vite - internal storiesOf projects
- Seems like project.json route is not working, which make metadata fail - Generated Storybook is not standard, which makes it incompatible with e2e tests
c8aebdb
to
96cf158
Compare
96cf158
to
3b2c3c4
Compare
Issue: #20886
What I did
This PR enables sandbox templates which were defined but still under
inDevelopment
treatment:Some tests were disabled for ssv6 given the lack of support for certain features.
Additionally, I changed the STORYBOOK_TEMPLATE_NAME variable to use the template
key
instead, which I believe everyone thought it was the key already, however it was using the readablename
property.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]