Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csf-tools: Fix error handling for storySort variable references #20930

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 4, 2023

Closes #20883

What I did

Provide a better error messages for storySort values that reference variables, which is not handled.

How to test

See repro in #20883

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)

@shilman
Copy link
Member Author

shilman commented Feb 4, 2023

Self-merging @ndelangen thanks @zhyd1997 !!! 🙏

@shilman shilman merged commit 293d52c into next Feb 4, 2023
@shilman shilman deleted the shilman/20883-improve-error-message branch February 4, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook 7 beta 40 crashes if preview storySort is a reference to an array
1 participant