Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed infinite render loop #2100

Merged
merged 3 commits into from
Oct 22, 2017
Merged

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Oct 20, 2017

Issue: #1747

What I did

fixed the issue

How to test

check the below URL repo
https://github.com/mattrothenberg/storybook-test

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #2100 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage    21.4%   21.41%   +<.01%     
==========================================
  Files         263      263              
  Lines        5793     5796       +3     
  Branches      695      695              
==========================================
+ Hits         1240     1241       +1     
- Misses       4015     4016       +1     
- Partials      538      539       +1
Impacted Files Coverage Δ
addons/knobs/src/vue/index.js 30.43% <50%> (+0.43%) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 9.09% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b87140...bacbec7. Read the comment docs.

@kazupon kazupon changed the title 🐛 bug(knobs): fixed infinite render loop fixed infinite render loop Oct 20, 2017
@kazupon kazupon added the vue label Oct 20, 2017
@Hypnosphi
Copy link
Member

Please don't use "closes" and "fixes" magic words, we close the issues only after release. When a PR gets merged, we simply mark the issue with merged label: https://github.com/storybooks/storybook/blob/master/CONTRIBUTING.md#closing-issues

@Hypnosphi Hypnosphi added the bug label Oct 21, 2017
@Hypnosphi Hypnosphi requested a review from a team October 21, 2017 12:06
@kazupon
Copy link
Member Author

kazupon commented Oct 21, 2017

sorry, I'll be more careful 🙇

@Hypnosphi Hypnosphi merged commit 8b99a86 into storybookjs:master Oct 22, 2017
@kazupon kazupon deleted the fixes/issue-1747 branch October 22, 2017 23:16
@ndelangen
Copy link
Member

Please don't use "closes" and "fixes" magic words, we close the issues only after release. When a PR gets merged, we simply mark the issue with merged label: https://github.com/storybooks/storybook/blob/master/CONTRIBUTING.md#closing-issues

Something to discuss on the Roadmap meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants