Vite: Update dep range for @storybook/mdx1-csf #21123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
A change was made in @storybook/mdx1-csf which we are relying on here, so we need a more precise version range in our dev and peer deps. Otherwise things will break for users who have an older version of mdx1-csf installed and try to use it by setting the feature flag.
How to test
Install
@storybook/mdx1-csf@1.0.0-next.0
and enable mdx1 feature flag in a vite project, and you'll get something likemdx is not defined
. Install@storybook/mdx1-csf@1.0.0-next.1
and it will be fixed.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]