Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Update dep range for @storybook/mdx1-csf #21123

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Feb 16, 2023

What I did

A change was made in @storybook/mdx1-csf which we are relying on here, so we need a more precise version range in our dev and peer deps. Otherwise things will break for users who have an older version of mdx1-csf installed and try to use it by setting the feature flag.

How to test

Install @storybook/mdx1-csf@1.0.0-next.0 and enable mdx1 feature flag in a vite project, and you'll get something like mdx is not defined. Install @storybook/mdx1-csf@1.0.0-next.1 and it will be fixed.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen
Copy link
Member

@shilman 👀 ?

@shilman shilman merged commit 43ac0aa into next Feb 17, 2023
@shilman shilman deleted the vite/mdx1-version branch February 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants