-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodocs: Hide Stories block when only primary story exists #21178
Autodocs: Hide Stories block when only primary story exists #21178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JReinhold Is there somewhere I can see an example of this in one of the test Storybooks? |
After discussing this with @MichaelArestad we decided that the primary story's description should be featured below the component description in the case of single stories. See screenshots below, and Chromatic UI Review: https://www.chromatic.com/pullrequest?appId=635781f3500dd2c49e189caf&number=21178&view=changes The only downside here is the fact that we now loose the narrative that "The Single storyMultiple stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this too, tho it lacks the simplicity of before. Please update the PR description before merging 🙏
…-single-story-show-the-same-story-twice
…-single-story-show-the-same-story-twice
Closes #20969
What I did
This PR adds a special case to the default
DocsPage
block for single story autodocs:How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]