Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact: Enable ts plugin by default #21225

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Preact: Enable ts plugin by default #21225

merged 1 commit into from
Feb 23, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Feb 23, 2023

What I did

  • Fix an issue where preact-ts sandboxes where failing because of TS compile errors after introducing actual TS syntax in the preview template

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template preact-webpack5/default-ts
  2. See the init script working again

-->

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen self-assigned this Feb 23, 2023
@kasperpeulen kasperpeulen added bug ci:daily Run the CI jobs that normally run in the daily job. labels Feb 23, 2023
@kasperpeulen kasperpeulen merged commit 7516e92 into next Feb 23, 2023
@kasperpeulen kasperpeulen deleted the fix-preact-ts branch February 23, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants