Core: Add preview.js default export support
#21227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
force-pushed
the
rollback-preview-ts-template
branch
from
b7cc2d3 to
2ca966c
Compare
kasperpeulen
added
the
ci:daily
kasperpeulen
force-pushed
the
rollback-preview-ts-template
branch
from
6050b8e to
daeb65f
Compare
kasperpeulen
force-pushed
the
rollback-preview-ts-template
branch
from
daeb65f to
9b6b6b4
Compare
kasperpeulen
changed the title
shilman
changed the title
shilman
changed the title
preview.js default export support
shilman
approved these changes
Feb 23, 2023
yannbf
reviewed
Feb 23, 2023
| argTypes: { x: '2', z: '2', obj: { a: '2', c: '2' } }, | ||
| globals: { x: '2', z: '2', obj: { a: '2', c: '2' } }, | ||
| globalTypes: { x: '2', z: '2', obj: { a: '2', c: '2' } }, | ||
| default: { |
There was a problem hiding this comment.
Could you add a case where this is mixed? We are composing configs that could come from users, addons, presets and frameworks, which will definitely be mixed and the composing of it all should work correctly
There was a problem hiding this comment.
Will do once CI finishes & merge
There was a problem hiding this comment.
It's all good – I tested that and added a telescoping PR for after we merge this: #21230
…econfig-test-case Build: Add mixed exports test case to composeConfigs
…to rollback-preview-ts-template
|
Edit: nevermind, it's all good! Hey @tmeasday if you have time, could you assist in getting Storybook in storyStoreV6 to support preview.js files that contain a default export? |
This was breaking the vue-cli templates and seems to be purely for pnp purposes: https://github.com/storybookjs/storybook/pull/21046/files#diff-76aad599d2311ab4fec53db693f2e85d4cb7f798cc37357dfe7839997caef2ba
tmeasday
force-pushed
the
rollback-preview-ts-template
branch
from
cef776d to
70a9e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that users can use export default in a
preview.ts/jsfile as well, as alternative of named exports.