Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix info upgrade codemod failing when optional description string is not supplied #2138

Merged
merged 3 commits into from
Oct 28, 2017

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Oct 27, 2017

Issue:

#2132

What I did

Added a check

How to test

Is this testable with jest or storyshots?
yes

Does this need a new example in the kitchen sink apps?
no

Does this need an update to the documentation?
no

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi
Copy link
Member

Please fix the unit test

@danielduan danielduan force-pushed the dd/fix-info-opt-desc branch from 58acab5 to dd4857f Compare October 28, 2017 01:29
@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #2138 into master will decrease coverage by <.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2138      +/-   ##
=========================================
- Coverage   21.41%   21.4%   -0.01%     
=========================================
  Files         263     263              
  Lines        5796    5812      +16     
  Branches      701     688      -13     
=========================================
+ Hits         1241    1244       +3     
- Misses       4000    4043      +43     
+ Partials      555     525      -30
Impacted Files Coverage Δ
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 49.01% <50%> (-2.15%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287414f...6599b38. Read the comment docs.

@danielduan danielduan merged commit de474b6 into master Oct 28, 2017
@danielduan danielduan deleted the dd/fix-info-opt-desc branch October 28, 2017 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants