Composition: Fix various CORS issues. #21682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21500 Closes #21501
What I did
It seems that
fetch()
can throw directly for various CORS related errors, rather than returning a response with{ ok: false }
.As we make 3 requests (
index.json
,stories.json
,metadata.json
) and it is common for servers to fail CORS when 404-ing, there's a good chance of hitting one of these (for instance Chakra does it onmetadata.json
, Chromatic does it onindex.json
<- 🐛 ).So I:
How to test
I used these three refs:
For the second you need access to the private repo and for the third you need to be running
npx http-server storybook-static --cors
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]