Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2081 #2117 fix prop type in react-native #2185

Merged
merged 2 commits into from
Oct 31, 2017
Merged

#2081 #2117 fix prop type in react-native #2185

merged 2 commits into from
Oct 31, 2017

Conversation

danielduan
Copy link
Member

Issue:

#2081 #2117
There is an optional prop was listed as required

What I did

Changed it to optional and added a defaultProp

How to test

Is this testable with jest or storyshots?
yes, passes the test with no changes
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #2185 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
- Coverage   21.43%   21.42%   -0.01%     
==========================================
  Files         263      263              
  Lines        5803     5805       +2     
  Branches      693      699       +6     
==========================================
  Hits         1244     1244              
+ Misses       4028     4026       -2     
- Partials      531      535       +4
Impacted Files Coverage Δ
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.97% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebe01f...f11e285. Read the comment docs.

@danielduan danielduan merged commit 7f5c890 into master Oct 31, 2017
@danielduan danielduan deleted the dd/rn-url-prop branch October 31, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants