Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Fix incorrect type-file for addon-actions #21922

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Bug: Fix incorrect type-file for addon-actions #21922

merged 1 commit into from
Apr 5, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 4, 2023 •
edited
Loading

Closes #21887

What I did

Fixes a small issue where types for decorators file from addon-actions was pointing to the wrong .d.ts file in package.json

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this Apr 4, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: actions typescript labels Apr 4, 2023
@ndelangen ndelangen requested a review from kasperpeulen April 4, 2023 16:39
@ndelangen
Copy link
Member Author

@jattasNI I think this fixes your issue

@ndelangen ndelangen changed the title fix https://github.com/storybookjs/storybook/issues/21887 Bug: Fix incorrect type-file for addon-actions Apr 4, 2023
kasperpeulen
kasperpeulen approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 5, 2023
@ndelangen ndelangen merged commit 57c0d4c into next Apr 5, 2023
@ndelangen ndelangen deleted the norbert/fix-21887 branch April 5, 2023 11:58
This was referenced Apr 5, 2023
Closed
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
@ndelangen @shilman
Merge pull request #21922 from storybookjs/norbert/fix-21887
20ee772 
Bug: Fix incorrect type-file for addon-actions
@shilman shilman mentioned this pull request Apr 6, 2023
Merged
4 tasks
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@ndelangen ndelangen

Labels
addon: actions maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 7.0.0 - Module '"@storybook/addon-actions/decorator"' has no exported member 'withActions'
3 participants
@ndelangen @kasperpeulen @shilman