-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1013 autoload all *.stories.js files in cli templates #2195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update CLI snapshots by running yarn test --cli --update
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2195 +/- ##
===============================================
- Coverage 21.73% 21.69% -0.05%
===============================================
Files 356 356
Lines 7071 7072 +1
Branches 925 902 -23
===============================================
- Hits 1537 1534 -3
- Misses 4835 4869 +34
+ Partials 699 669 -30
Continue to review full report at Codecov.
|
I don't think the CLI test is set up right. Either that, or the angular storybook doesn't work. Looks like there's a lot of missing dependencies |
Snapshot update should work anyway, it runs before smoke tests Please just run UPD: nevermind, I can see you already did that |
Issue:
#1013 we should try to autoload all *.stories.js to make user's lives easier
What I did
How to test
Is this testable with jest or storyshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.