Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE integration tests so they all output a diff image when multiple fail #2197

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

ndelangen
Copy link
Member

Issue: -no all diff images are saved when screenshots do not match-

What I did

I reworked the tests a bit so they re-use the same puppeteer page and both save diff file.

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 31, 2017
@ndelangen ndelangen self-assigned this Oct 31, 2017
@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #2197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2197   +/-   ##
=======================================
  Coverage   21.43%   21.43%           
=======================================
  Files         263      263           
  Lines        5803     5803           
  Branches      700      687   -13     
=======================================
  Hits         1244     1244           
- Misses       4018     4037   +19     
+ Partials      541      522   -19
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 49.01% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.7% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b83a9d...67d0f7c. Read the comment docs.

@ndelangen ndelangen merged commit aebe01f into master Oct 31, 2017
@ndelangen ndelangen deleted the ndelangen/improve-integration-tests branch October 31, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants