-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Remove mdx1-csf as optional peer dep #22038
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: @babel/core@7.12.9, @storybook/mdx1-csf@1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-merging @ndelangen
…peer-dep Addon-docs: Remove mdx1-csf as optional peer dep
Closes #21935
What I did
Remove
mdx1-csf
as optional peer dep. This will break strict package manager support for MDX1 (yarn pnp, pnpm) but will eliminate the security warnings for npm users, who are our largest user population by far).How to test
In a sandbox:
@storybook/mdx1-csf
as a dev dependencyfeatures.legacyMdx1 = true
inmain.js
{1 + 1}
inlined) is not evaluated