Upgrade eslint-config-airbnb and make it pass #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
commented
Nov 2, 2017
app/vue/src/client/index.js
Outdated
| export const addDecorator = previewApi.addDecorator; | ||
| export const configure = previewApi.configure; | ||
| export const getStorybook = previewApi.getStorybook; | ||
| export * from './preview'; |
There was a problem hiding this comment.
This actually adds one more exported value: cleanDecorators. LMK if there's a reason not to export it here
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
+ Coverage 21.42% 21.44% +0.02%
==========================================
Files 263 263
Lines 5807 5801 -6
Branches 692 695 +3
==========================================
Hits 1244 1244
- Misses 4032 4035 +3
+ Partials 531 522 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2149
The fixes mostly include switching to destructuring syntax