-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Migrate @storybook/addon-docs to strict-ts #22180
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
@@ -61,7 +61,7 @@ export class DocsRenderer<TRenderer extends Renderer> { | |||
element | |||
) | |||
) | |||
.then(resolve); | |||
.then(() => resolve()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday I think this is safe, but maybe you can double-check this, as I lack some context.
Basically, the TS type tells the Promise is void, but the Promise returns null in runtime.
So I make sure the API matches the runtime here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is fine I don't think we ever look at the result of the promise, just await it :)
@@ -61,7 +61,7 @@ export class DocsRenderer<TRenderer extends Renderer> { | |||
element | |||
) | |||
) | |||
.then(resolve); | |||
.then(() => resolve()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is fine I don't think we ever look at the result of the promise, just await it :)
Issue #22176
What I did
Build: Migrate @storybook/addon-docs to strict-ts
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]