Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate @storybook/addon-docs to strict-ts #22180

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

kasperpeulen
Copy link
Contributor

Issue #22176

What I did

Build: Migrate @storybook/addon-docs to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen self-assigned this Apr 20, 2023
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Apr 20, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
tiny-invariant@1.3.1 None +0 alexreardon

@kasperpeulen kasperpeulen changed the base branch from next to kasper/strict-ts April 20, 2023 10:49
@@ -61,7 +61,7 @@ export class DocsRenderer<TRenderer extends Renderer> {
element
)
)
.then(resolve);
.then(() => resolve());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmeasday I think this is safe, but maybe you can double-check this, as I lack some context.
Basically, the TS type tells the Promise is void, but the Promise returns null in runtime.
So I make sure the API matches the runtime here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine I don't think we ever look at the result of the promise, just await it :)

@@ -61,7 +61,7 @@ export class DocsRenderer<TRenderer extends Renderer> {
element
)
)
.then(resolve);
.then(() => resolve());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine I don't think we ever look at the result of the promise, just await it :)

Base automatically changed from kasper/strict-ts to next April 25, 2023 07:45
@kasperpeulen kasperpeulen merged commit 0b94967 into next Apr 25, 2023
@kasperpeulen kasperpeulen deleted the kasper/strict-ts-docs branch April 25, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants