Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX yarn test & selecting only core #2219

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

ndelangen
Copy link
Member

Issue: -yarn test followed by only selecting core was broken.

This was broken by some internal change by jest or something.
By proving a absolute path this seems to work again.

Added the executed command for clarity.

This was broken by some internal change by jest or something.
By proving a absolute path this seems to work again.

Added the executed command for clearity.
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Nov 2, 2017
@ndelangen ndelangen self-assigned this Nov 2, 2017
@ndelangen ndelangen requested a review from danielduan November 2, 2017 22:17
@danielduan danielduan merged commit 526f9e9 into master Nov 2, 2017
@danielduan danielduan deleted the ndelangen/fix-yarn-testscript branch November 2, 2017 22:23
@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #2219 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   21.44%   21.44%           
=======================================
  Files         263      263           
  Lines        5801     5801           
  Branches      689      692    +3     
=======================================
  Hits         1244     1244           
+ Misses       4024     4017    -7     
- Partials      533      540    +7
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2df1a1...238338f. Read the comment docs.

@danielduan danielduan added cli and removed cli labels Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants