Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix sandbox publish script #22206

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Build: Fix sandbox publish script #22206

merged 1 commit into from
Apr 21, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 21, 2023

Closes #

What I did

The sandbox publish script was not working because of a missing " in the command that generated the message 😮‍💨 however the script logs were just saying "nothing to commit", therefore showing a false success. The sandboxes repo hasn't been updated for a couple days already, so we are not testing the latest alphas.

This PR fixes that + improves the error handling so we don't fall into this situation again!

How to test

I tested this extensively, it's a little troublesome to do it locally without impacting the sandboxes repo so please reach out and I can give all details to do so if you'd like

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Apr 21, 2023
@yannbf yannbf merged commit 716df0b into next Apr 21, 2023
@yannbf yannbf deleted the fix/sandbox-publish-script branch April 21, 2023 16:55
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 24, 2023
shilman pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants