Build: Fix sandbox publish script #22206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
The sandbox publish script was not working because of a missing
"
in the command that generated the message 😮💨 however the script logs were just saying "nothing to commit", therefore showing a false success. The sandboxes repo hasn't been updated for a couple days already, so we are not testing the latest alphas.This PR fixes that + improves the error handling so we don't fall into this situation again!
How to test
I tested this extensively, it's a little troublesome to do it locally without impacting the sandboxes repo so please reach out and I can give all details to do so if you'd like
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]