fix bad typings file caused by https://github.com/egoist/tsup/issues/782 #22261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate. Turns out this is a much wider problem. This fixes all of them, not just in the html renderer. I agree these changes aren't the best. we should contact the authors of the tooling and get these problems addressed.
shilman
reviewed
Apr 27, 2023
ndelangen
added
the
patch:yes
|
@shilman I think this is a critical bugfix |
|
just one example: before: after: |
kasperpeulen
reviewed
May 1, 2023
| import { withBackground } from './decorators/withBackground'; | ||
| import { withGrid } from './decorators/withGrid'; | ||
| import { PARAM_KEY } from './constants'; | ||
|
|
||
| export const decorators = [withGrid, withBackground]; | ||
| export const decorators: Addon_DecoratorFunction[] = [withGrid, withBackground]; |
There was a problem hiding this comment.
I would just use import type { DecoratorFunction } from '@storybook/types';
There was a problem hiding this comment.
These types are pretty much equal. When we do the types cleanup at 8.0 we'll sync this up.
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 3, 2023
…dition fix bad typings file caused by egoist/tsup#782
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21820
Closes #22288
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]