Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Persist sessionId across runs #22325

Merged
merged 4 commits into from
May 2, 2023
Merged

Telemetry: Persist sessionId across runs #22325

merged 4 commits into from
May 2, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 30, 2023

Closes N/A

What I did

  • Persist sessionId into cache for 2h
  • Tests by ChatGPT

How to test

  • Attached unit tests
  • Manual tests
    • Run a sandbox locally multiple times & verify same sessionId
    • Delete node_modules/.cache folder & verify new sessionId

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Apr 30, 2023
@shilman shilman marked this pull request as draft April 30, 2023 13:30
@shilman shilman requested a review from tmeasday April 30, 2023 13:30
tmeasday
tmeasday approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@shilman shilman self-assigned this May 1, 2023
@shilman shilman marked this pull request as ready for review May 1, 2023 15:40
@shilman shilman merged commit 86e6206 into next May 2, 2023
@shilman shilman deleted the shilman/persistent-session-id branch May 2, 2023 16:25
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels May 3, 2023
shilman added a commit that referenced this pull request May 3, 2023
@shilman
Merge pull request #22325 from storybookjs/shilman/persistent-session-id
9fb339b 
Telemetry: Persist sessionId across runs
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@shilman shilman

Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday