Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-modal to 3.1.0 #2238

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Update react-modal to 3.1.0 #2238

merged 1 commit into from
Nov 6, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #2162

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #2238 into master will increase coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
+ Coverage   22.16%   22.16%   +<.01%     
==========================================
  Files         268      268              
  Lines        5875     5878       +3     
  Branches      707      713       +6     
==========================================
+ Hits         1302     1303       +1     
- Misses       4024     4042      +18     
+ Partials      549      533      -16
Impacted Files Coverage Δ
lib/ui/src/modules/ui/components/search_box.js 80% <20%> (-4.38%) ⬇️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/knobs/src/KnobStore.js 9.09% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 19.54% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c14f67...5db6040. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should bring us to full react 16 compatibility right?

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Nov 6, 2017

We are fully compatible as is, this just removes one of the peerDependency warnings and makes use of the new renderPortal feature when it’s available

@Hypnosphi Hypnosphi merged commit c004ee6 into master Nov 6, 2017
@Hypnosphi Hypnosphi deleted the update-react-modal branch November 6, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants