Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @storybook/addon-storyshots-puppeteer to strict TS #22407

Merged
merged 3 commits into from
May 31, 2023
Merged

Migrate @storybook/addon-storyshots-puppeteer to strict TS #22407

merged 3 commits into from
May 31, 2023

Conversation

1234tgk
Copy link
Contributor

@1234tgk 1234tgk commented May 5, 2023

Issue #22176

What I did

Adjust the code so that the package allows strict typing.

How to test

Run yarn check on @storybook/addon-storyshots-puppeteer directory.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@1234tgk 1234tgk changed the title Migrate @storybook/addon-storyshots-puppeteer to strict TS Migrate @storybook/addon-storyshots-puppeteer to strict TS [WIP] May 5, 2023
@1234tgk 1234tgk force-pushed the ts-migrate/storyshots-puppeteer branch from 847de96 to 42b9cae Compare May 5, 2023 22:33
@1234tgk 1234tgk changed the title Migrate @storybook/addon-storyshots-puppeteer to strict TS [WIP] Migrate @storybook/addon-storyshots-puppeteer to strict TS May 6, 2023
@1234tgk 1234tgk force-pushed the ts-migrate/storyshots-puppeteer branch from 42b9cae to d031abd Compare May 8, 2023 03:19
@1234tgk 1234tgk force-pushed the ts-migrate/storyshots-puppeteer branch 2 times, most recently from d3a2ff1 to f1d6a59 Compare May 10, 2023 06:52
@1234tgk 1234tgk mentioned this pull request May 14, 2023
Closed
@1234tgk 1234tgk force-pushed the ts-migrate/storyshots-puppeteer branch from f1d6a59 to 20dde1a Compare May 21, 2023 21:25
@kasperpeulen kasperpeulen self-requested a review May 31, 2023 08:43
kasperpeulen
kasperpeulen approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 31, 2023
@kasperpeulen kasperpeulen merged commit 746b994 into storybookjs:next May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1234tgk @kasperpeulen