fix windows path when importing storybook-init-renderer-entry #22512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
May 11, 2023
There was a problem hiding this comment.
@michens Thank you for your contribution!
LGTM and tested on Windows.
valentinpalkovic
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 12, 2023
fix windows path when importing storybook-init-renderer-entry
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22091
What I did
Updated slashes for importing
rendererInitEntrywhenstoryStoreV7isfalseSimilar to #20430
How to test
Not sure, as
yarn task --task sandbox --start-from auto --template internal/ssv6-webpackseems to work, even without this.However, I made this change in node_modules, and verified that storybook was able to build with it, and failed without it
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]