CLI: Fix getFrameworkPackage
logic
#22559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #18360
What I did
The CLI had a bug in the way it tried to detect a framework package. That caused the following issue:
Sorry, for now, you can not do this, please use a framework such as @storybook/react-webpack5
This PR fixes that bug, and also throws a descriptive error to assist users in case they hit this scenario
How to test
storybook init --builder XYZ
:a.
--builder vite
(should work)b.
--builder @storybook/builder-vite
(should work)c.
--builder vitest
(should throw an error telling you to check if the package exists)Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]