Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate @storybook/addon-mdx-gfm to strict TS #22659

Merged
merged 2 commits into from
May 31, 2023

Conversation

1234tgk
Copy link
Contributor

@1234tgk 1234tgk commented May 21, 2023

Issue #22176

What I did

Adjust the code so that the package allows strict typing.

How to test

Run yarn check on @storybook/addon-mdx-gfm directory.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 31, 2023
@kasperpeulen kasperpeulen merged commit 934a868 into storybookjs:next May 31, 2023
@jonniebigodes
Copy link
Contributor

@1234tgk, one thing left to address as part of this initiative and the amazing work you did by helping us convert Storybook's packages to allow stricter TypeScript support. If you're ok with it, can you message me on our Discord server ( same username) so that I can follow up with you?

Hope you have a fantastic day.

Stay safe

@1234tgk
Copy link
Contributor Author

1234tgk commented Jul 25, 2023

@jonniebigodes Hello! Which discord channel should I message you from? I've only send messages at wg-typescript channel previously.

@jonniebigodes
Copy link
Contributor

If you're ok with it, you can message me directly, or if you're not comfortable with it, drop a message in the wg-typescript channel and tag me and I'll follow up with you.

@1234tgk
Copy link
Contributor Author

1234tgk commented Jul 25, 2023

@jonniebigodes Just sent you a friend request instead since I couldn't send a DM to you (Discord blocked me from doing so)

@jonniebigodes
Copy link
Contributor

@1234tgk no worries there. I just saw the notification and will follow up with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants