Addon-info: allow duplicate displayNames #2269
Conversation
| </h2> | ||
| const propTables = array.map((type, i) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <div key={`${getName(type)}_${i}`}> |
There was a problem hiding this comment.
I think it's OK to use indices in this case
Codecov Report
@@ Coverage Diff @@
## master #2269 +/- ##
==========================================
+ Coverage 22.13% 22.14% +0.01%
==========================================
Files 268 268
Lines 5892 5893 +1
Branches 715 712 -3
==========================================
+ Hits 1304 1305 +1
- Misses 4044 4052 +8
+ Partials 544 536 -8
Continue to review full report at Codecov.
|
|
|
||
| const TextArea = hoc(({ children }) => <textarea>{children}</textarea>); | ||
|
|
||
| storiesOf('GitHub issues', module).add( |
There was a problem hiding this comment.
Naming it github issues isn't very helpful. Maybe Addon Info.HOC and withInfo('Allow Duplicate DisplayNames for HOC #1814')?
There was a problem hiding this comment.
I wanted to introduce a single namespace for reproductions, so that it's easy to find one
There was a problem hiding this comment.
I understand, but ultimately, I still think this is a Addon Info thing. If we have 20 different Github issues and I'm making a change to Addon Info, I wouldn't think to check all the Github ones for regressions you know?
Maybe Addon Info.Github Issues and that description I had earlier?
Issue: #1814
When using HOCs, different component types may have the same names. #1607 fixed it for
nameproperty, but duplicatediplayNames still lead to "same key" warnings.What I did
Added indices to propTable div keys
How to test
yarn start& open http://localhost:9010/?selectedKind=GitHub%20issues&selectedStory=%231814