Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility warnings #2270

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Fix accessibility warnings #2270

merged 3 commits into from
Nov 9, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Nov 9, 2017

Issue: Some elements of storybook UI are unusable with keyboard. They have click handlers and even tabindex attributes, but no keyboard handlers.

What I did

Used <button type="button"/> in those cases. It sometimes required a bit of style resetting

How to test

Navigate to following elements with tab and hit Enter key:
— tab headings in addons panel
— color picker in addon-knobs
— "Show info" button in addon-info

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #2270 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
+ Coverage   22.16%   22.16%   +<.01%     
==========================================
  Files         268      268              
  Lines        5884     5883       -1     
  Branches      711      714       +3     
==========================================
  Hits         1304     1304              
+ Misses       4060     4018      -42     
- Partials      520      561      +41
Impacted Files Coverage Δ
...mments/src/manager/components/CommentItem/style.js 0% <ø> (ø) ⬆️
...mments/src/manager/components/CommentItem/index.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (+0.11%) ⬆️
...b/ui/src/modules/ui/components/down_panel/index.js 96% <100%> (ø) ⬆️
addons/info/src/components/Story.js 76.19% <100%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.13% <0%> (ø) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48fbd3...36c7eb8. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 7f535b4 into master Nov 9, 2017
@Hypnosphi Hypnosphi deleted the fix-accessibility-warnings branch November 9, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants