-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type: update Addon_BaseAnnotations
type
#22771
Merged
ndelangen
merged 8 commits into
storybookjs:next
from
specialdoom:my-first-storybook-contribution
May 30, 2023
Merged
type: update Addon_BaseAnnotations
type
#22771
ndelangen
merged 8 commits into
storybookjs:next
from
specialdoom:my-first-storybook-contribution
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
patch:yes
Bugfix & documentation PR that need to be picked to main branch
bug
labels
May 25, 2023
ndelangen
approved these changes
May 25, 2023
Is something stopping us from merging this PR if everything is alright? I would like to add the change on the addon repo as well. Sorry for pushing... |
ndelangen
approved these changes
May 30, 2023
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jun 4, 2023
shilman
pushed a commit
that referenced
this pull request
Jun 4, 2023
…ution type: update `Addon_BaseAnnotations` type
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've added extra type variable for the
Addon_BaseAnnotations
which is related to the renderer that it's going to be passed toAddon_StoryContext
. These types are used inside@storybook/addon-svelte-csf
addon for theStoryProps
type whereplay
function it's included.Using the current implementation of the
@storybook/addon-svelte-csf
theplay
function has theAddon_StoryContext
with default type variableTRenderer
equal toRenderer
which hascanvasElement
property as unknown. I'm adding the extra type variable to be able to specify theRenederer
so I can have a known type for thecanvasElement
property. Thesvelte-check
command it's returning an error because of theunknown
type of thecanvasElement
property.If this PR will be merged there is going to be another PR on the
@storybook/addon-svelte-csf
which it's going to use the newAddon_BaseAnnotations
type.e.g.
Current usage of
Addon_BaseAnnotation
in@storybook/addon-svelte-csf
here .How to reproduce issue https://stackblitz.com/github/StefanIlieP5/svelte-storybook7
npm run check
command["other"]