-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3: Fix TS 5.0 compat with vue-component-type-helpers #22814
Conversation
…extract prop types compatible with TS 5.0
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @kasperpeulen !!! 🚀
Vue3: Fix TS 5.0 compat with vue-component-type-helpers
nice @kasperpeulen, did you try "vue-component-type-helpers" it small but great for ComponentProps. ,ComponentSlots ...., i'm using in the new implementation for docs Argtypes table |
what about my PR #22285 ? you checked it ? nobody did although i have written a documentation not only PR description 😁 |
What I did
Use type helpers of the official vue-component-type-helpers to extract prop types compatible with TS 5.0.
This fixes reported bugs in discord when using a recent version of vscode, or using vue-tsc together with TS 5.0.
This also adds missing default props to our args autocompletion! (Such as "class").
How to test
Use a recent version of VSCode, select TS 5.0 and then see the public type tests for vue working with this PR.
I haven't upgraded the monorepo to TS 5.0 yet, will do in a seperate PR.
What we really need to figure out is, how to run our type test in sandboxes, so that we are sure they don't regress with version bumps.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]