-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: E2E tests for Source block update fix #22835
Conversation
…torybookjs/storybook into build/fix-next-chromatic-tests
So @shilman, you can see it is failing now on next branch. |
…' into chaks/fix-update-source-snippet
Thanks for the repro @chakAs3 very helpful! |
…ippet Docs: Fix Source block snippet updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…n-docs Docs: E2E tests for Source block update fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman I need to look deeper into the Block implementation, it seems an easy task, but I'm not aware of the reasons behind tell implementation.
In my opinion, The block should be only responsible for how the snippet will be rendered ( layout, design aspect+ show/hide/copy actions ). the Optimisation should be done in the decorator level. which is the case I guess at least for Vue, we only fire the RERENDRED_SNIPPET event if the args are changed.
Closes #
What I did
this an e2e to for sourceSnippet should faild if the source is not changing back to previous value
should be merged after #22807
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]