Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2196 - Set console.warn and console.error to throw in tests #2297

Merged
merged 3 commits into from
Nov 21, 2017

Conversation

dangreenisrael
Copy link
Member

Issue: #2196

What I did

Set tests to fail on prop-type warnings

How to test

  • Run the tests, they should fail if there are prop type warnings.

Notes

Is this testable with jest or storyshots?
jest
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
no
If your answer is yes to any of these, please make sure to include it in your PR.

@Hypnosphi Hypnosphi added ci: do not merge maintenance User-facing maintenance tasks labels Nov 12, 2017
@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

Merging #2297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2297   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files         283      283           
  Lines        6155     6155           
  Branches      726      727    +1     
=======================================
  Hits         1307     1307           
+ Misses       4301     4293    -8     
- Partials      547      555    +8
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 9.09% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 31.37% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.3% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad0dc2...041deca. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 72e5c97 into master Nov 21, 2017
@Hypnosphi Hypnosphi deleted the make-console-error-and-log-fail-tests-#2196 branch November 21, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants