-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use @storybook published deprecated dependencies #2314
Conversation
Nice! LGTM! Do I need to test before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielduan see comment above
@shilman I tested on vue, cra, and crna. We'll see if this netlify thing works too. |
I'm really confused about the |
Codecov Report
@@ Coverage Diff @@
## master #2314 +/- ##
=======================================
Coverage 21.19% 21.19%
=======================================
Files 283 283
Lines 6156 6156
Branches 724 730 +6
=======================================
Hits 1305 1305
+ Misses 4302 4288 -14
- Partials 549 563 +14
Continue to review full report at Codecov.
|
Issue: temporarily relieves #2303
What I did
forked all the komposer/mantra deprecated packages and published version without peer dependency warning
How to test
Is this testable with jest or storyshots?
n
Does this need a new example in the kitchen sink apps?
n
Does this need an update to the documentation?
n
If your answer is yes to any of these, please make sure to include it in your PR.