Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @storybook published deprecated dependencies #2314

Merged
merged 3 commits into from
Nov 15, 2017

Conversation

danielduan
Copy link
Member

Issue: temporarily relieves #2303

What I did

forked all the komposer/mantra deprecated packages and published version without peer dependency warning

How to test

Is this testable with jest or storyshots?
n
Does this need a new example in the kitchen sink apps?
n
Does this need an update to the documentation?
n
If your answer is yes to any of these, please make sure to include it in your PR.

@danielduan danielduan added dependencies maintenance User-facing maintenance tasks labels Nov 15, 2017
@shilman
Copy link
Member

shilman commented Nov 15, 2017

Nice! LGTM! Do I need to test before we merge?

@danielduan danielduan changed the title Dd/deprecated dependencies use @storybook published deprecated dependencies Nov 15, 2017
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielduan see comment above

@danielduan
Copy link
Member Author

@shilman I tested on vue, cra, and crna. We'll see if this netlify thing works too.

@danielduan
Copy link
Member Author

danielduan commented Nov 15, 2017

I'm really confused about the build yarn failure. I just ran that command it gave and it didn't change anything.

@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #2314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2314   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      724      730    +6     
=======================================
  Hits         1305     1305           
+ Misses       4302     4288   -14     
- Partials      549      563   +14
Impacted Files Coverage Δ
lib/ui/src/compose.js 33.33% <ø> (ø) ⬆️
lib/ui/src/index.js 13.33% <ø> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 48.8% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203cf78...d9f8ef3. Read the comment docs.

@danielduan danielduan merged commit 4ef3d96 into master Nov 15, 2017
@danielduan danielduan deleted the dd/deprecated-dependencies branch November 15, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants