Issue 2196 fix unittest warnings #2343
Conversation
…nto issue-2196_fix-unittest-warnings
Codecov Report
@@ Coverage Diff @@
## master #2343 +/- ##
==========================================
+ Coverage 21.2% 21.23% +0.03%
==========================================
Files 283 283
Lines 6155 6155
Branches 736 714 -22
==========================================
+ Hits 1305 1307 +2
- Misses 4271 4303 +32
+ Partials 579 545 -34
Continue to review full report at Codecov.
|
| // <a> and <pre> elements, which is why <div> | ||
| // is used as the outputted element when parsing | ||
| // marksy content rather than <p>. | ||
| return <div style={style}>{props.children}</div>; | ||
| } | ||
|
|
||
| P.defaultProps = defaultProps; |
There was a problem hiding this comment.
Maybe we should change the component name too? Looks like it's now called P, but renders a DIV.
Thanks to the comment we do know why though 👍 .
There was a problem hiding this comment.
Yeah it would make sense to change it, but in that case, do we go ahead and distinguish when the component is used as a wrapper and when it's just used as <p> tag? Or if not, what do we rename this to?
There was a problem hiding this comment.
Great!
@syneva-runyan can you do the same for release/3.3 branch after we merge this PR?
|
@Hypnosphi sure. |
|
@syneva-runyan please uncomment those lines when making the PR for |
Issue: #2196
What I did
Fixed warning being outputting from unit tests.