Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep examples' deps up to date #2353

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: When publishing, the @storybook/* packages' versions don't get updated in examples. The reason is ignore section in lerna.json. Actually, it's safe to remove this section, because the examle packages are marked as private and won't get published anyway

@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #2353 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage   21.38%   21.23%   -0.15%     
==========================================
  Files         283      283              
  Lines        6182     6155      -27     
  Branches      863      725     -138     
==========================================
- Hits         1322     1307      -15     
- Misses       4223     4297      +74     
+ Partials      637      551      -86
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-44.12%) ⬇️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 9.09% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed6e1f...3c87c1a. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from shilman November 22, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants