Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose style for customisation #2370

Merged
merged 1 commit into from
Nov 25, 2017
Merged

Conversation

baktiaditya
Copy link
Contributor

@baktiaditya baktiaditya commented Nov 25, 2017

Issue:

What I did

Cannot modify button.topRight style from storybook config.js

example:

import { setDefaults } from '@storybook/addon-info';
import deepmerge from 'deepmerge';

setDefaults({
  styles: (defaultStyles) => {
    return deepmerge(defaultStyles, {
      button: {
        topRight: {
          right: 'auto',
          borderRadius: '0 0 5px 0',
          left: 0,
        },
      },
    });
  },
});

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@Hypnosphi
Copy link
Member

Hypnosphi commented Nov 25, 2017

@codecov
Copy link

codecov bot commented Nov 25, 2017

Codecov Report

Merging #2370 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2370   +/-   ##
=======================================
  Coverage   19.92%   19.92%           
=======================================
  Files         293      293           
  Lines        6484     6484           
  Branches      754      768   +14     
=======================================
  Hits         1292     1292           
+ Misses       4625     4592   -33     
- Partials      567      600   +33
Impacted Files Coverage Δ
addons/info/src/components/Story.js 76.47% <100%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/knobs/src/KnobManager.js 31.37% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0876476...09ff079. Read the comment docs.

@baktiaditya
Copy link
Contributor Author

@Hypnosphi 👍 done

@baktiaditya baktiaditya changed the title Expose button style for customisation Expose style for customisation Nov 25, 2017
Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again

@Hypnosphi Hypnosphi merged commit da27501 into storybookjs:master Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants