Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vue storybook boilerplate #2421

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Conversation

Maxhodges
Copy link
Contributor

Issue: Storybook for Vue with Vuetify Material Component Framework takes some time to setup. Also new users to Vue may not understand how to wrap a layout around a component (which isn't addressed in the current docs).

What I did

Created a boilerplate Storybook-for-Vue project using Vuetify Material Component Framework. Having something like this would have helped me get started much faster. So I'm sharing for others. Includes stories for a component with two states and a layout which wraps the component.

How to test

demo deployed to GitPages
https://white-rabbit-japan.github.io/vuetify-storyboard-boilerplate/

Is this testable with jest or storyshots?
I don't think so.

Does this need a new example in the kitchen sink apps?
Example exists in GitPages if you want to include.

Does this need an update to the documentation?
Probably not. But I did find some issues in the docs which I'll pull request separately.

If your answer is yes to any of these, please make sure to include it in your PR.

having something like this would have helped me get started much faster. So I'm sharing for others. Includes a layout and composed component with a state toggle story
@codecov
Copy link

codecov bot commented Dec 3, 2017

Codecov Report

Merging #2421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2421   +/-   ##
=======================================
  Coverage   16.64%   16.64%           
=======================================
  Files         302      302           
  Lines        7769     7769           
  Branches      787      775   -12     
=======================================
  Hits         1293     1293           
- Misses       5832     5870   +38     
+ Partials      644      606   -38
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/info/src/components/Node.js 39.13% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 19.54% <0%> (ø) ⬆️
app/react/src/demo/Button.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
addons/jest/src/components/PanelTitle.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1fe20...1a5a772. Read the comment docs.

@ndelangen ndelangen merged commit d5f45a3 into storybookjs:master Dec 4, 2017
@Maxhodges Maxhodges deleted the patch-2 branch December 4, 2017 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants