Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addon events into its own story file #2502

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

tmeasday
Copy link
Member

A pretty simple change to refactor the events stories out of index.stories.js. Seems to make sense.

@tmeasday
Copy link
Member Author

Tests seem to be broken?

@igor-dv
Copy link
Member

igor-dv commented Dec 18, 2017

@tmeasday, looks like you need to update the snapshots

@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #2502 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2502   +/-   ##
============================================
  Coverage        19.51%   19.51%           
============================================
  Files              386      386           
  Lines             8707     8707           
  Branches           945      962   +17     
============================================
  Hits              1699     1699           
+ Misses            6292     6260   -32     
- Partials           716      748   +32
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/actions/src/lib/types/nan/index.js 29.41% <0%> (ø) ⬆️
addons/actions/src/lib/retrocycle.js 34.09% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 16.66% <0%> (ø) ⬆️
...s/actions/src/lib/types/function/createFunction.js 26.66% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 29.78% <0%> (ø) ⬆️
addons/actions/src/lib/util/muteProperty.js 14.28% <0%> (ø) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0feacbb...2145e67. Read the comment docs.

@tmeasday tmeasday merged commit 6bf9701 into release/3.3 Dec 18, 2017
@ndelangen ndelangen deleted the tmeasday/move-events-stories branch December 18, 2017 12:59
@ndelangen
Copy link
Member

Thanks, great work! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants