-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix whitespace on info add-on card #2543
Conversation
Thanks you for your first PR @lachlanjc! Looks like you need to run the unit tests and update the snapshots for this to be merge-able. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, can you update the unit tests snapshots?
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
=======================================
Coverage 32.68% 32.68%
=======================================
Files 398 398
Lines 8838 8838
Branches 943 961 +18
=======================================
Hits 2889 2889
+ Misses 5300 5278 -22
- Partials 649 671 +22
Continue to review full report at Codecov.
|
@ndelangen 1.46GB of downloads and 20 minutes later, updated 🙈✨ |
Issue: info add-on cards have no bottom spacing, so story components run up against the card.
Before:
After:
Please let me know if this needs to be fixed/updated anywhere else!