Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace on info add-on card #2543

Merged
merged 3 commits into from
Dec 26, 2017
Merged

Conversation

lachlanjc
Copy link
Contributor

Issue: info add-on cards have no bottom spacing, so story components run up against the card.

Before:
screen shot 2017-12-23 at 4 58 31 pm

After:
screen shot 2017-12-23 at 4 59 06 pm

Please let me know if this needs to be fixed/updated anywhere else!

@ndelangen
Copy link
Member

Thanks you for your first PR @lachlanjc!

Looks like you need to run the unit tests and update the snapshots for this to be merge-able.
Do you need any help with that?

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can you update the unit tests snapshots?

@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 24, 2017
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #2543 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2543   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files         398      398           
  Lines        8838     8838           
  Branches      943      961   +18     
=======================================
  Hits         2889     2889           
+ Misses       5300     5278   -22     
- Partials      649      671   +22
Impacted Files Coverage Δ
addons/info/src/components/Story.js 88.88% <100%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 18.51% <0%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db33dc...2f56ab3. Read the comment docs.

@lachlanjc
Copy link
Contributor Author

@ndelangen 1.46GB of downloads and 20 minutes later, updated 🙈✨

@Hypnosphi Hypnosphi dismissed ndelangen’s stale review December 26, 2017 02:57

Snapshots updated

@Hypnosphi Hypnosphi merged commit e0b5f00 into storybookjs:master Dec 26, 2017
@lachlanjc lachlanjc deleted the patch-1 branch December 26, 2017 03:13
@Hypnosphi Hypnosphi removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants