Use store revisions to ensure that stories re-render on HMR. #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can confirm that HMR is not working in vue when you change e.g. a story definition in |
|
There wasn't objections, only questions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking #2588 fro #2241.
I think we should also check the revision number on this line: https://github.com/storybooks/storybook/blob/10ed61dd9e82ad00bfa31872ffc140dfeebe9d42/app/vue/src/client/preview/render.js#L63
But I would prefer a Vue expert to weigh in on that.
Also we should probably rebase/something
shilman/refactor-core. This should hopefully cleanly apply in any case.Finally, @Hypnosphi perhaps suggested some objections to this approach. I think this is the place to discuss them.