Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip serializing (Synthetic)Events #2626

Merged
merged 2 commits into from
Jan 3, 2018
Merged

skip serializing (Synthetic)Events #2626

merged 2 commits into from
Jan 3, 2018

Conversation

rhalff
Copy link
Contributor

@rhalff rhalff commented Jan 3, 2018

Revert old behavior of handling SyntheticEvents passed to the action handlers.

Fixes: #2590

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #2626 into master will increase coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
+ Coverage   32.61%   32.65%   +0.04%     
==========================================
  Files         397      398       +1     
  Lines        8855     8868      +13     
  Branches      954      959       +5     
==========================================
+ Hits         2888     2896       +8     
+ Misses       5304     5298       -6     
- Partials      663      674      +11
Impacted Files Coverage Δ
addons/actions/src/lib/util/index.js 100% <ø> (ø) ⬆️
addons/actions/src/preview.js 61.53% <100%> (-3.17%) ⬇️
addons/actions/src/lib/util/prepareArguments.js 57.14% <87.5%> (ø)
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/viewport/src/components/SelectViewport.js 15% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
...-native/src/preview/components/OnDeviceUI/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 87.23% <0%> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 911e615...a81df1f. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, made some other comment on #2590

@Hypnosphi Hypnosphi merged commit 2fab220 into storybookjs:master Jan 3, 2018
@Hypnosphi Hypnosphi added patch:yes Bugfix & documentation PR that need to be picked to main branch performance issue labels Jan 3, 2018
shilman pushed a commit that referenced this pull request Jan 7, 2018
skip serializing (Synthetic)Events
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants