-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .ts compatibility to storyshots #2639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
Coverage 34.33% 34.33%
=======================================
Files 388 388
Lines 8682 8682
Branches 901 908 +7
=======================================
Hits 2981 2981
+ Misses 5097 5074 -23
- Partials 604 627 +23
Continue to review full report at Codecov.
|
Perhaps we should add an example showing typescript usage? if that's not too cumbersome in a monorepo? |
All angular examples are actually in typescript, Do you think we need something for react ? |
No, doesn't seem necessary to me, but if whoever reading this, disagrees, let us know :) |
…ibility Add .ts compatibility to storyshots
Issue: #2630
What I did
A quick fix to make ts stories to work well with stoyshots and
multiSnapshotWithOptions
.#2517 might revisit the ability to customize stoyshots file names.