Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ts compatibility to storyshots #2639

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jan 4, 2018

Issue: #2630

What I did

A quick fix to make ts stories to work well with stoyshots and multiSnapshotWithOptions.
#2517 might revisit the ability to customize stoyshots file names.

@igor-dv igor-dv self-assigned this Jan 4, 2018
@igor-dv igor-dv added addon: storyshots compatibility with other tools patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 4, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #2639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files         388      388           
  Lines        8682     8682           
  Branches      901      908    +7     
=======================================
  Hits         2981     2981           
+ Misses       5097     5074   -23     
- Partials      604      627   +23
Impacted Files Coverage Δ
addons/storyshots/src/utils.js 87.5% <ø> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.42% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
...tions/src/lib/types/function/createFunctionEval.js 77.77% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
addons/jest/src/components/PanelTitle.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/retrocycle.js 54.54% <0%> (ø) ⬆️
addons/actions/src/lib/decycle.js 53.52% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cfce1...9e5019c. Read the comment docs.

@ndelangen
Copy link
Member

Perhaps we should add an example showing typescript usage? if that's not too cumbersome in a monorepo?

@igor-dv
Copy link
Member Author

igor-dv commented Jan 4, 2018

All angular examples are actually in typescript, Do you think we need something for react ?

@ndelangen
Copy link
Member

No, doesn't seem necessary to me, but if whoever reading this, disagrees, let us know :)

@igor-dv igor-dv merged commit 51108ef into master Jan 4, 2018
@igor-dv igor-dv deleted the storyshots-ts-stories-compatibility branch January 4, 2018 12:43
shilman pushed a commit that referenced this pull request Jan 7, 2018
…ibility

Add .ts compatibility to storyshots
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: storyshots compatibility with other tools patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants