Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @angular/core dep from knobs peer. #2640

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jan 4, 2018

Issue: I don't remember where it was mentioned

What I did

We don't want people to install deps of every supported framework, that's why I remove @angular/core from the peer.

@igor-dv igor-dv self-assigned this Jan 4, 2018
@igor-dv igor-dv added addon: knobs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 4, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #2640 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2640   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files         388      388           
  Lines        8682     8682           
  Branches      903      889   -14     
=======================================
  Hits         2981     2981           
- Misses       5082     5109   +27     
+ Partials      619      592   -27
Impacted Files Coverage Δ
addons/knobs/src/angular/helpers.js 0% <ø> (ø) ⬆️
addons/knobs/src/angular/utils.js 0% <0%> (ø) ⬆️
app/react/src/demo/Welcome.js 64.7% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
...tions/src/lib/types/function/createFunctionEval.js 77.77% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc322f...2ce834e. Read the comment docs.

@ndelangen ndelangen merged commit 27cfce1 into master Jan 4, 2018
@ndelangen ndelangen deleted the knobs-peer-deps-fix branch January 4, 2018 12:09
shilman pushed a commit that referenced this pull request Jan 7, 2018
Remove @angular/core dep from knobs peer.
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants